Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the intent of the DPs #7

Open
cmungall opened this issue May 9, 2024 · 2 comments
Open

Clarify the intent of the DPs #7

cmungall opened this issue May 9, 2024 · 2 comments

Comments

@cmungall
Copy link
Member

cmungall commented May 9, 2024

Should the DPs be consolidated in the Uberon repo?

Having said that I am likely lacking a lot of context about vccfo

E.g. I am looking at vessel

DP:

https://github.com/obophenotype/vccf-ontology/blob/main/src/patterns/dosdp-patterns/vessel.yaml

Data:

https://github.com/obophenotype/vccf-ontology/blob/main/src/patterns/data/default/vessel.tsv

This doesn't really conform to how we might do it in uberon.

E.g. if I see

def:
  text: "A vessel located in %s"

I expect a logical definition too

see principle S11 from DefinitionConstraintComponent

However, I don't think that's the purpose of this DP. I think this is more like a robot template?

E.g.

defined_class label human_label parent location xrefs synonym synonym_xrefs taxon
2 VCCF:1000000 left atrium left atrium (Human) UBERON:0002079 heart chamber https://en.wikipedia.org/wiki/Heart Left atrium FMA::7097

The Uberon DP would be a laterality one here.

@cmungall
Copy link
Member Author

cmungall commented May 9, 2024

So we also have this

https://github.com/obophenotype/vccf-ontology/blob/main/src/templates/vessel_organ_crosswalk.tsv

I don't really get why we're dividing the axioms between two TSVs

@anitacaron
Copy link
Collaborator

The DOSDP is still in draft mode, and we need to discuss that in the meeting. The second template is different because it comes from a different source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants