-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a Postgres database dependency to test with Docker? #121
Comments
I'm ok with using containers in the testing environment. Actually, in the first version of the tests, I have used docker and docker-compose for Observatorium API. There are good initiatives out there to make life easier to test with docker. For example https://github.com/testcontainers/testcontainers-go. It worths checking it out. Let's see what other maintainers also think. |
|
Since we use kind for testing, using docker shouldn't be a thing blocking us. If we intend to use postgres as a backend for the observatorium-api, then why not package the deployment for tests in jsonnet and install it along with former in kind? Am I missing the point here? |
Sgtm, even using a programmatic framework like test containers sounds awesome. However, I worry that a full blown overhaul will be a big effort that will hold up the PostgreSQL work for a long time. Can we do an intermediate transition to make things work in the short term and then a full migration? Specifically, keep the test script as is and just run PostgreSQL with docker and later, after the PostgreSQL work is merged, do a full overhaul. WDYT? |
So far we have all tests running straight up binaries. I don't think that's feasible with Postgres anymore.
I'm happy to be proven otherwise, but I think running a simple Docker container makes a lot more sense for this going forward.
Isn't this a big deal to begin with or should we try to make it work without Docker?
WDYT?
The text was updated successfully, but these errors were encountered: