Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observatorium operator should support customized pull secret #69

Open
marcolan018 opened this issue May 12, 2021 · 1 comment
Open

observatorium operator should support customized pull secret #69

marcolan018 opened this issue May 12, 2021 · 1 comment

Comments

@marcolan018
Copy link

currently observatorium CRD doesn't expose the pull secret. If the images are located in private repo and requires customized pull secret to pull them, observatorium operator cannot help on that.
Workaround is to set the pull secret as the default one for the deploy namespace. But it's better for operator to support it so that users can specify the pull secret in the CR.

@squat
Copy link
Member

squat commented May 12, 2021

Yes, this is a good point. This is also a good example of how the current Observatorium CRD is not well designed. It's monolithic and still not big enough! We should probably break this CRD into smaller ones that directly include Pod templates so that Observatorium does not need to explicitly handle all Kubernetes-related fields and types.

saswatamcode pushed a commit to saswatamcode/observatorium-operator that referenced this issue May 21, 2024
* support remote write endpoints
Signed-off-by: Marco [email protected]

* observatorium cr refacotoring
Signed-off-by: Marco [email protected]

* jb update
Signed-off-by: Marco [email protected]

* add mountPath in EndpointConfig
Signed-off-by: Marco [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants