Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SASL_SSL #17

Closed
thammuio opened this issue Aug 8, 2019 · 4 comments
Closed

Support for SASL_SSL #17

thammuio opened this issue Aug 8, 2019 · 4 comments
Labels
question Further information is requested

Comments

@thammuio
Copy link

thammuio commented Aug 8, 2019

Does this support SASL_SSL.

@ekoutanov
Copy link
Member

Discussed in #9.

TL;DR: Possibly, but not tested.

@ekoutanov ekoutanov added the question Further information is requested label Aug 9, 2019
@shaaimin
Copy link
Contributor

shaaimin commented Aug 23, 2019

@ekoutanov
after i added some code on KafkaHighLevelAdminClient.java, it works well for me.
add the following after line28
if (kafkaConfiguration.getIsSecured()) {
props.put(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG, kafkaConfiguration.getSecurityProtocol());
props.put(SaslConfigs.SASL_MECHANISM, kafkaConfiguration.getSaslMechanism());
}

another issue is exception occurred when show cluster-overview and broker detail page since host in BrokerVO which was got from kafkaMonitor.getBrokers() is null.
also i found a similar case as below.
Yelp/kafka-utils#157

revise the following parts, it works well.
cluster-overview.ftl
line92
${b.host?if_exists}
broker-detail.ftl
line42
${broker.host?if_exists}:${broker.port}

i tried to create a branch and then create pullrequest, it seems no auth for me to do that.

@ekoutanov
Copy link
Member

Hi @shaaimin. To a PR, it's best to fork the repo, make your change into your master, then raise the PR.

@shaaimin
Copy link
Contributor

Hi @ekoutanov. I had raised the PR, please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants