Results aggregation broken

[kayceesrk]

I'm running Sandmark manually with the following run_all_serial.sh file:

#!/bin/bash

TAG='"macro_bench"' make run_config_filtered.json

OPT_WAIT=0 USE_SYS_DUNE_HACK=1 RUN_CONFIG_JSON=run_config_filtered.json make ocaml-versions/5.0.0+trunk.bench
OPT_WAIT=0 USE_SYS_DUNE_HACK=1 RUN_CONFIG_JSON=run_config_filtered.json make ocaml-versions/5.0.0+trunk+volatile_field.bench

When the run completes, I just have results/_1.orun.summary.bench file. The expectation is that I should have two files:

• 5.0.0+trunk_1.orun.summary.bench
• 5.0.0+trunk+volatile_field.orun.summary.bench

This is a regression. Not sure what's broken. The README hasn't been updated with additional instructions if there is supposed to be a different workflow.

[kayceesrk]

Looks like there is a SANDMARK_CUSTOM_NAME variable in the Makefile, which is undocumented. My suggestion would be

1. Either make SANDMARK_CUSTOM_NAME a mandatory argument that terminates the make early if an argument is not given or pick it up automatically from the name of the variant where the variant is ocaml-versions/<variant>.json.
2. Document this in the README.md file.
3. Fix the run_all_*.sh files appropriately.

[kayceesrk]

Nit: Now that SANDMARK_CUSTOM_NAME looks mandatory, it is better named as VARIANT_NAME.