Refactor update_major_slice_work and major GC work units #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rearrange code in this function to separate computation of allocations done
from computation of next slice work budget, to more easily replace the latter
- Better log messages from slice computation
- Separate units of marking and sweeping work, and add unit conversions
- Rename 'work_counter' and 'alloc_counter'
NickBarnes
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
LGTM. Good to separate the notions of sweep work and mark work (hmm, could use the type system for that). A couple of suggestions, mostly naming. As anticipated, this will mean I have to rework #3587 when rebasing, but of course I'm not going to do that until after your next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearrange code in this function to separate computation of allocations done from computation of next slice work budget, to more easily replace the latter
Better log messages from slice computation
Separate units of marking and sweeping work, and add unit conversions
Rename 'work_counter' and 'alloc_counter'