Fix bug related to speculative inlining and data flow #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gbury
added
bug
Gbury
force-pushed
the
fix_loopify_dataflow
branch
2 times, most recently
from
e1d428b to
185115e
Compare
Gbury
force-pushed
the
fix_loopify_dataflow
branch
from
185115e to
f83a746
Compare
|
@lthls this should be good to merge I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that can happen when loopifying a function, where during speculative inlining, data_flow would be run with call to the
selfcontinuation, but in a context whereselfis not known to data_flow (since we are only analyzing the inlined body, whereselfis not bound).The solution here is simply to not perform loopification of calls during speculative inlining. Note that once the inlining decision is made, when we rebuild the actual term, we still loopify as before, i.e. the patch only affects speculative inlining (where compilation currently fails, so we do not lose anything). Nevertheless, in the future, we may be interested in trying to count the benefit of the loopification.
Note: this is a 2 line-change (plus some comment for explanation), the rest is re-indentation, so reviewers are encouraged to use the ignore-whitespace-diff option.