Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import doesn't work for submodules #20

Open
gerdstolpmann opened this issue Dec 24, 2017 · 3 comments
Open

Import doesn't work for submodules #20

gerdstolpmann opened this issue Dec 24, 2017 · 3 comments
Assignees

Comments

@gerdstolpmann
Copy link

e.g.

# module M = struct type t = int end;;
module M : sig type t = int end
# type t = [%import: M.t] [@@deriving show];;
Error: [%import]: cannot locate module M

I just ran into the issue because I couldn't add the [@@deriving] clause directly to the module M for formal reasons (a bad interaction with include module type of), so I thought I could derive in another module defined in the same file. Fortunately, I could work around my moving M to a file of its own. Neverthless, this restriction was a surprise.

@whitequark
Copy link
Contributor

Related to #14

@xguerin xguerin self-assigned this Jan 16, 2018
@xguerin xguerin changed the title import doesn't work for submodules Import doesn't work for submodules Jan 16, 2018
@xguerin
Copy link
Contributor

xguerin commented Jan 16, 2018

The import logic for submodules is incomplete. Related to #22. I'll look into it.

@Pitometsu
Copy link

Pitometsu commented Sep 10, 2019

v. 1.6.2 still the same. Didn't it be fixed in some commit yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants