Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the module type syntax #74

Open
tatchi opened this issue Sep 9, 2022 · 2 comments · May be fixed by #87
Open

Update the module type syntax #74

tatchi opened this issue Sep 9, 2022 · 2 comments · May be fixed by #87
Assignees
@tatchi
Milestone
2.0

Comments

@tatchi
Copy link
Collaborator

tatchi commented Sep 9, 2022

To match the new type declaration implemented in #68

module type Hashable = [%import: (module Hashtbl.HashedType)] would become module type%import Hashable = Hashtbl.HashedType
@tatchi
Copy link
Collaborator Author

tatchi commented Sep 9, 2022 •
edited
Loading

@ejgallego it doesn't seem I've the right to change the milestone. Do you mind doing it?

@ejgallego
Copy link
Collaborator

Ooops, I've tried to fix the permissions, you should have an invite.

@ejgallego ejgallego added this to the 2.0 milestone Sep 9, 2022
@tatchi tatchi self-assigned this Feb 6, 2023
@tatchi tatchi linked a pull request Feb 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatchi tatchi

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Implement new module type syntax tatchi/ppx_import
2 participants
@tatchi @ejgallego