-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Ast_pattern
error reporting.
#391
Comments
Hello, I'd like to work on this issue |
I noticed that on the referenced issue, changes were made in the ocaml-ppx/ppx-import. I've successfully cloned and built ocaml-ppx/ppxlib. Will I need to clone multiple extensions of ocaml-ppx? Or do I stick with ppxlib for now? |
Hello @nangahamandine, I think for this issue you will need just the ppxlib |
Sure, thanks |
Hi @nangahamandine, I wish to find out if you've completed this issue already! |
hey! I am an outreachy applicant, I would like to work on this issue. can you please assign it to me? |
@nangahamandine are you still actively working on this issue? Do not hesitate to ask for support, or precision on the task. But let us know if the issue can be assigned to someone else! If this issue is already taken, there are others with still no-one working on them, listed on #389. |
Well, sir @panglesd, I'd hoped to but since I meet a comment on it from @nangahamandine, I thought she has been reading through, and perhaps working on it too: |
I've not been able to do much. My time commitments changed so I've had little to no time to make changes or contributions |
The error reported by
Ast_pattern
are not very informative, especially for the user of the PPX, who might not know anything about the AST.Here is an example of an error generated by an unmatched AST pattern:
Possible improvements:
Error: a "structure" node was expected, instead of a "..."
alt
function, which only expects from one branch. Example of a custom error message (see Implement new module type syntax ppx_import#87):The text was updated successfully, but these errors were encountered: