Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml.ppx.context's local_path format changes in OCaml 5.2 #475

Closed
NathanReb opened this issue Feb 15, 2024 · 1 comment
Closed

ocaml.ppx.context's local_path format changes in OCaml 5.2 #475

NathanReb opened this issue Feb 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@NathanReb
Copy link
Collaborator

Starting from 5.2 we won't be able to read [@@@ocaml.ppx.context ...] attributes from older versions. This prevents users to run the driver on binary ASTs from older versions if the driver is built with ocaml 5.2 or above.

We can provide support for this by rewriting those attributes during the migrations. We could also consider not supporting this for arbitrarily old binary ASTs but I would not recommend we go down that road unless it requires a lot of effort to maintain which I don't think is the case here.

After #474 is merged, our test suite won't catch this bug anymore so I'm opening this issue not to lose track of this bug.

As a first step we at least need to fix or improve this test, or add another one so we do catch this bug.

@NathanReb NathanReb added the bug Something isn't working label Feb 15, 2024
@NathanReb NathanReb self-assigned this Feb 15, 2024
@NathanReb
Copy link
Collaborator Author

This has been fixed on trunk-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant