-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
learn-ocaml build -j 2
is broken
#414
Comments
As an aside, when this bug will be fixed: we may want to add a |
I have examined this a bit, and it attempts to use So the option should just be disabled at this point. The more reasonable implementation could be:
Or, of course, we could wait for multicore which should make it fairly trivial 🚀 |
Hi @AltGr, thanks a lot for investigating, and for these pointers.
Yes, that sounds a good trade-off → and replacing the BTW, I've just skimmed the open issues, and it seems this had been spotted some time ago; |
Bug description
It seems there's a race condition in
learn-ocaml build
that prevents us from safely using the--jobs
option.To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/ocaml-sf/learn-ocaml.git
)cd learn-ocaml
docker pull ocamlsf/learn-ocaml:master
)docker run --rm -it -v "$PWD/demo-repository:/repository" ocamlsf/learn-ocaml:master -j 2
Then, there is high probability that we get:
if the repository contains 2+ exercises (which is now the case of demo-repository).
Expected behavior
No error should happen.
The text was updated successfully, but these errors were encountered: