feat: multiple foreign language support #11849
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make foreign_language.t a polymorphic variant to allow for more fine grained casing in the foreign library rules and also to allow for shorter names. We also cleanup some dead code. Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Alizter
added a commit
to Alizter/dune
that referenced
this pull request
May 25, 2025
We make foreign_language.t a polymorphic variant to allow for more fine grained casing. Later, as outlined in ocaml#11849, we will add more foreign languages, so it is important that we can refer to a subset of the foreign languages for later language specific rules. We also do some routine cleanup and dead code removal. Signed-off-by: Ali Caglayan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add support for multiple foreign languages to be specified in a single
foreign_stubsfield orforeign_library. These fields/stanzas now take alanguagesfield to allow manual specification of languages or alternatively can be omitted defaulting to automatic language detection.We also add support for Assembly language.
I'll mark this PR as draft for the time being so that I can separate out the commits and get them merged separately. This PR will be undrafted when the main feature is ready to be reviewed.