-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why is arch-x86_32/arch-x86_64 marked with flags: compiler
? also msys2* and system-mingw/system-msvc
#27080
Comments
opam 2.0 complains if you specify base packages which aren’t flagged compiler. It became less relevant in opam 2.1 and IIRC in opam 2.2 we got rid of all remaining interpretations of the compiler flag in opam itself |
Oops - a pre-caffeinated answer. The removal I was referring to is mentions of base packages, not the interpretation of the compiler flag itself. The answer for why thoe msys2, arch- and system- packages are flagged compiler is opam 2.0 base package-related. For the issue in dra27#21, the issue is that opam uses the |
Thanks for your reply @dra27 - I still not fully understand that, but if it is needed for opam 2.0, then let's leave it as is. |
FWIW, this pollutes the
|
Since those packages are windows related and opam 2.0 doesn't support windows it feels unnecessary to have that flag for those packages |
Cross-referencing #17541 which confirms I had remembered correctly! I agree with @kit-ty-kate, though, for the Windows-specific msys2- ones. I'll try to get a PR done for it (the slow part is getting round to testing it...!) |
//cc @dra27 @kit-ty-kate -- related to dra27#21
The text was updated successfully, but these errors were encountered: