Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] pcre (8.0.0) #27125

Closed
wants to merge 1 commit into from
Closed

Conversation

mmottl
Copy link
Contributor

@mmottl mmottl commented Dec 17, 2024

Bindings to the Perl Compatibility Regular Expressions library

CHANGES:
  • Removed superfluous and buggy subj_start argument. This fixes a bug in
    the full_split function where non-capturing groups are not identified
    as such.
  • Removed obsolete base-bytes dependency

CHANGES:

- Removed superfluous and buggy `subj_start` argument. This fixes a bug in
  the `full_split` function where non-capturing groups are not identified
  as such.
- Removed obsolete base-bytes dependency
@mseri
Copy link
Member

mseri commented Dec 19, 2024

There is a failure that I wonder if it has always been a problem or if it may be related to the release. The failing code path is coming from https://github.com/swuecho/camelsnakekebab/blob/master/lib/camelsnakekebab.ml#L18 and the failure is

#=== ERROR while compiling camelsnakekebab.0.4 ================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.2.1 | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/camelsnakekebab.0.4
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p camelsnakekebab
# exit-code            1
# env-file             ~/.opam/log/camelsnakekebab-7-4bf8b5.env
# output-file          ~/.opam/log/camelsnakekebab-7-4bf8b5.out
### output ###
# File "lib_test/dune", lines 6-10, characters 0-79:
#  6 | (alias
#  7 |  (name    runtest)
#  8 |   (deps    basic.exe)
#  9 |   (action  (run ./basic.exe))
# 10 | )
# (cd _build/default/lib_test && ./basic.exe)
# FF...F.....
# ==============================================================================
# Error: suite_case:10:test11.
# 
# File "/home/opam/.opam/5.2/.opam-switch/build/camelsnakekebab.0.4/_build/default/lib_test/oUnit-suite_case-builder#02.log", line 5, characters 1-1:
# Error: suite_case:10:test11 (in the log).
# 
# Raised at OUnitAssert.assert_failure in file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 2-27
# Called from OUnitRunner.run_one_test.(fun) in file "src/lib/ounit2/advanced/oUnitRunner.ml", line 83, characters 13-26
# 
# not equal
# ------------------------------------------------------------------------------
# ==============================================================================
# Error: suite_case:4:test5.
# 
# File "/home/opam/.opam/5.2/.opam-switch/build/camelsnakekebab.0.4/_build/default/lib_test/oUnit-suite_case-builder#05.log", line 2, characters 1-1:
# Error: suite_case:4:test5 (in the log).
# 
# Raised at OUnitAssert.assert_failure in file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 2-27
# Called from OUnitRunner.run_one_test.(fun) in file "src/lib/ounit2/advanced/oUnitRunner.ml", line 83, characters 13-26
# 
# not equal
# ------------------------------------------------------------------------------
# ==============================================================================
# Error: suite_case:3:test4.
# 
# File "/home/opam/.opam/5.2/.opam-switch/build/camelsnakekebab.0.4/_build/default/lib_test/oUnit-suite_case-builder#04.log", line 2, characters 1-1:
# Error: suite_case:3:test4 (in the log).
# 
# Raised at OUnitAssert.assert_failure in file "src/lib/ounit2/advanced/oUnitAssert.ml", line 45, characters 2-27
# Called from OUnitRunner.run_one_test.(fun) in file "src/lib/ounit2/advanced/oUnitRunner.ml", line 83, characters 13-26
# 
# not equal
# ------------------------------------------------------------------------------
# Ran: 11 tests in: 0.11 seconds.
# FAILED: Cases: 11 Tried: 11 Errors: 0 Failures: 3 Skip:  0 Todo: 0 Timeouts: 0.

Can you double check?

@mmottl
Copy link
Contributor Author

mmottl commented Dec 20, 2024

Thanks for the warning, this seems to be a bug. I'll submit again once it is fixed.

@mmottl mmottl closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants