Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ppx_deriving_yojson.3.9.1 #27142

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

NathanReb
Copy link
Contributor

@NathanReb NathanReb commented Dec 18, 2024

CHANGES

@kit-ty-kate
Copy link
Member

for opam-repository maintainers or you if you have the time: once merged it might be worth restricting all previous releases of ppx_deriving_yojson to OCaml < 5.3 (see ocaml-ppx/ppx_deriving_yojson#161) using

opam admin add-constraint 'ocaml<5.3' --packages ppx_deriving_yojson

@NathanReb
Copy link
Contributor Author

for opam-repository maintainers or you if you have the time: once merged it might be worth restricting all previous releases of ppx_deriving_yojson to OCaml < 5.3 (see ocaml-ppx/ppx_deriving_yojson#161) using

Sure thing, I'll do it!

@NathanReb
Copy link
Contributor Author

I think the revdeps failure are unrelated, I'll proceed with the actual release!

@NathanReb NathanReb force-pushed the release-ppx_deriving_yojson.3.9.1 branch from 9f2445d to aae8886 Compare December 19, 2024 09:44
@NathanReb NathanReb marked this pull request as ready for review December 19, 2024 09:46
@mseri
Copy link
Member

mseri commented Dec 19, 2024

Just observed the issue with previous derivers:

#=== ERROR while compiling ojs_base.0.8.0 =====================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0~beta1 | pinned(https://zoggy.frama.io/ojs-base/releases/ojs-base-0.8.0.tar.bz2)
# path                 ~/.opam/5.3~beta1/.opam-switch/build/ojs_base.0.8.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ojs_base -j 31 --promote-install-files=false @install
# exit-code            1
# env-file             ~/.opam/log/ojs_base-7-bc7d97.env
# output-file          ~/.opam/log/ojs_base-7-bc7d97.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3~beta1/bin/ocamlc.opt -g -w -40 -bin-annot -w -6-7-9-10-27-32-33-34-35-36-39-50-52 -no-strict-sequence -g -bin-annot -bin-annot-occurrences -I lib/.ojs_base.objs/byte -I /home/opam/.opam/5.3~beta1/lib/lwt -I /home/opam/.opam/5.3~beta1/lib/ppx_deriving/runtime -I /home/opam/.opam/5.3~beta1/lib/ppx_deriving_yojson/runtime -I /home/opam/.opam/5.3~beta1/lib/seq -I /home/opam/.opam/5.3~beta1/lib/yojson -no-alias-deps -open Ojs_base -o lib/.ojs_base.objs/byte/ojs_base__Types.cmi -c -intf lib/types.pp.mli)
# File "_none_", line 1:
# Error: broken invariant in parsetree: Explicit universal type quantification cannot be empty.

@mseri
Copy link
Member

mseri commented Dec 19, 2024

The CI is re-running, so I need to wait for it to finish before I can merge

@NathanReb
Copy link
Contributor Author

This issue is the one that this version fixes, or is supposed to fix at least. Where did you get that error?

@mseri mseri merged commit 9699c1b into ocaml:master Dec 20, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Dec 20, 2024

Looks all right, thanks!

mseri added a commit to mseri/opam-repository that referenced this pull request Dec 20, 2024
@mseri
Copy link
Member

mseri commented Dec 20, 2024

This was before this PR was merged indeed, seen on #27081

@NathanReb
Copy link
Contributor Author

Ah nice, thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants