-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release ppx_deriving_yojson.3.9.1 #27142
Release ppx_deriving_yojson.3.9.1 #27142
Conversation
for opam-repository maintainers or you if you have the time: once merged it might be worth restricting all previous releases of ppx_deriving_yojson to OCaml < 5.3 (see ocaml-ppx/ppx_deriving_yojson#161) using
|
Sure thing, I'll do it! |
I think the revdeps failure are unrelated, I'll proceed with the actual release! |
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
9f2445d
to
aae8886
Compare
Just observed the issue with previous derivers:
|
The CI is re-running, so I need to wait for it to finish before I can merge |
This issue is the one that this version fixes, or is supposed to fix at least. Where did you get that error? |
Looks all right, thanks! |
See ocaml#27142 Signed-off-by: Marcello Seri <[email protected]>
This was before this PR was merged indeed, seen on #27081 |
Ah nice, thanks for letting me know! |
CHANGES
Poly_typ ([], ...)
nodes when deriving de/serializer for open types. These are rejected by OCaml 5.3 onward. (add version 0.4.15 of archimedes, vorbis and pulseaudio bindings #162) @NathanReb