-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few improvements #27
Open
eugenesvk
wants to merge
81
commits into
occivink:master
Choose a base branch
from
eugenesvk:all
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid OSD means not only that 'OSD-dimensions' property returns a table, but also that the values of this table are non-0
Avoids conflicts with other script within the same folder since it provides unique IDs
Avoids conflicts with other script within the same folder since it provides unique IDs
Avoids conflicts with other script within the same folder since it provides unique IDs
it sends messages to other scripts, so better load those earlier
Still not 100% correct as window scaling may emit two OSD property change events, so we trigger alignment on 2 non-zero OSD calls BUT: we can't differentiate whether this was auto-scaling-call on launch or a valid user call, so user's first manual alignment might get overriden by this fix
-1 left/down +1 right/up
Allows to set these in a better color space vs the default hex
reformat to tabular view add more image movement commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my fork I've made a few improvements listed below, so opening this PR in case you'd like to incorporate them into your repo as well:
mpvi
in bothmpv.conf
and andinput.conf
to allow people to just copy&paste configs to their own profilesYAML
(though an older version due to lua's outdated libraries) that also allows tabular formatting with comments and doesn't bug if you add a=
,
in92,92
, a space is fine (though it should be flexible and auto-detect,
as well)