Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to how we save the logs #45

Merged
merged 11 commits into from
Feb 11, 2025
Merged

Updates to how we save the logs #45

merged 11 commits into from
Feb 11, 2025

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Jan 30, 2025 •
edited
Loading

Fixes #40
Fixes: #41

Changes proposed in this PR:

  • Updates to how we save the logs
  • Logs are streamed to a separate output console "Algorithm Logs" so that the user can follow them in real time.
  • The complete log file is opened when the compute job is completed.

image

@jamiehewitt15 jamiehewitt15 marked this pull request as draft January 30, 2025 09:52
@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review January 30, 2025 14:50
mariacarmina
mariacarmina approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, lgtm. I think also getStreamable logs functionality will be part of ocean.js, until then we can use fetch requests.

src/helpers/freeCompute.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll do that before merging

@jamiehewitt15 jamiehewitt15 merged commit 06c4975 into main Feb 11, 2025
@jamiehewitt15 jamiehewitt15 deleted the issue-#40-saving-logs branch February 11, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open the log file automatically upon completion. Save the logs in a separate file.
2 participants
@jamiehewitt15 @mariacarmina