From df23d88ba09488040260d5193df596f8a0af5ad1 Mon Sep 17 00:00:00 2001 From: Diego Hurtado Date: Tue, 25 Jun 2024 18:14:43 -0600 Subject: [PATCH] Fix equality tests --- .../test_exponential_bucket_histogram.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/opentelemetry-sdk/tests/metrics/integration_test/test_exponential_bucket_histogram.py b/opentelemetry-sdk/tests/metrics/integration_test/test_exponential_bucket_histogram.py index 545ee23b06..0192fbbcc3 100644 --- a/opentelemetry-sdk/tests/metrics/integration_test/test_exponential_bucket_histogram.py +++ b/opentelemetry-sdk/tests/metrics/integration_test/test_exponential_bucket_histogram.py @@ -108,7 +108,11 @@ def test_synchronous_delta_temporality(self): ) self.assertEqual(metric_data.min, self.test_values[index + 1]) self.assertEqual(metric_data.max, self.test_values[index + 1]) - self.assertEqual(metric_data.sum, self.test_values[index + 1]) + # Using assertAlmostEqual here because in 3.12 resolution can cause + # these checks to fail. + self.assertAlmostEqual( + metric_data.sum, self.test_values[index + 1] + ) results = [] @@ -200,7 +204,7 @@ def test_synchronous_cumulative_temporality(self): self.assertEqual( metric_data.max, max(self.test_values[: index + 2]) ) - self.assertEqual( + self.assertAlmostEqual( metric_data.sum, sum(self.test_values[: index + 2]) ) @@ -254,7 +258,7 @@ def test_synchronous_cumulative_temporality(self): ) self.assertEqual(metric_data.min, min(self.test_values)) self.assertEqual(metric_data.max, max(self.test_values)) - self.assertEqual(metric_data.sum, sum(self.test_values)) + self.assertAlmostEqual(metric_data.sum, sum(self.test_values)) previous_metric_data = metric_data @@ -272,7 +276,7 @@ def test_synchronous_cumulative_temporality(self): ) self.assertEqual(previous_metric_data.min, metric_data.min) self.assertEqual(previous_metric_data.max, metric_data.max) - self.assertEqual(previous_metric_data.sum, metric_data.sum) + self.assertAlmostEqual(previous_metric_data.sum, metric_data.sum) self.assertEqual( metric_data.positive.bucket_counts,