Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX12 backend can't render into a multisampled frame buffer #7708

Open
zixin96 opened this issue Jun 18, 2024 · 1 comment
Open

DX12 backend can't render into a multisampled frame buffer #7708

zixin96 opened this issue Jun 18, 2024 · 1 comment

Comments

@zixin96
Copy link

zixin96 commented Jun 18, 2024

Version/Branch of Dear ImGui:

Version 1.90.8, Branch: master (no modifications)

Back-ends:

imgui_impl_win32.cpp + imgui_impl_dx12.cpp

Compiler, OS:

Windows 11 + MSVC 2022

Details:

Similar to this closed issue #2705 (comment), I think DX12 backend can't render into a multisampled frame buffer too. I tried to incorporate IMGUI into my dx12 MSAA demo that got these kinds of errors: D3D12 ERROR: ID3D12CommandList::DrawIndexedInstanced: The render target sample desc in slot 0 does not match that specified by the current pipeline state.(pipeline state = count 1 quality 0, render target view = count 4 quality 0, ID3D12Resource* = 0x000001B5709919C0:'MSAA Render Target') [ EXECUTION ERROR #614: RENDER_TARGET_SAMPLE_DESC_MISMATCH_PIPELINE_STATE]. A quick search reveals that SampleDesc.Count is set to 1 for all its occurrences in imgui_impl_dx12.cpp.
Is this something we'd like to do? Thanks.

@ocornut
Copy link
Owner

ocornut commented Jun 18, 2024

Can you confirm which occurrences of SamplerDesc.Count are required to be changed?

We should probably start converging toward a similar solution as the Vulkan backend, where user on Init provide a struct with various information needed to match your render target. But we need to take account of the fact that secondary viewports created (in the docking branch) may use a different set of settings (those may always be Count == 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants