Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: data-time range parameters do not seem to be working correctly #497

Closed
1 task done
doowb opened this issue Jul 25, 2024 · 4 comments
Closed
1 task done

[BUG]: data-time range parameters do not seem to be working correctly #497

doowb opened this issue Jul 25, 2024 · 4 comments
Labels
Type: Bug Something isn't working as documented

Comments

@doowb
Copy link

doowb commented Jul 25, 2024

What happened?

I'm using @octokit/core to list workflow runs based on the REST API docs. I'm attempting to use the created parameter with a date-time formatted as 2024-07-24T17:00:00Z, but I don't get any results back. When I only use the date 2024-07-24, I get the correct results back, so I'm not sure if there is a bug in this library (when encoding the parameter), the actual github api, or if the docs need to be updated to specify that only the date portion of the date-time range is available.

Versions

Octokit: v6.1.2
Node.js: v20.15.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@doowb doowb added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Jul 25, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

That would be a bug with GitHub itself. We don't parse values given as parameters

@doowb
Copy link
Author

doowb commented Jul 25, 2024

Thanks for getting back to me so fast!

Do you know where I can open a bug report for the GitHub API?

@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Aug 2, 2024
@kfcampbell
Copy link
Member

kfcampbell commented Aug 2, 2024

IIRC in the past we've pointed people to Community discussions for these types of issues, although you can also file a bug report.

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

No branches or pull requests

3 participants