Replies: 11 comments
-
Hi @saschanaz, very cool to see that you use Octokit for the CSS Working Group drafts! Just so I understand it right: you want your bot account to create merge commits to resolve conflicts in current pull requests? In the Is the use case to basically rebase open pull requests on latest master? |
Beta Was this translation helpful? Give feedback.
-
Right, but only for existing PRs that the bot opened, because the bot knows what should be done for them.
That's what I do as a workaround for now, but rebasing always closes existing PRs and thus causes a need to open new PRs whenever conflicts happen. |
Beta Was this translation helpful? Give feedback.
-
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Beta Was this translation helpful? Give feedback.
-
@bcoe I think you run into this challenge before? Did you end up resolving it? |
Beta Was this translation helpful? Give feedback.
-
👋 for our case, we always update the branch from The problem we were running into, was making the PR not close and reopen every time we update from |
Beta Was this translation helpful? Give feedback.
-
You mean you solved that problem? I wonder how 🧐 |
Beta Was this translation helpful? Give feedback.
-
@saschanaz here's the logic that's mostly been working for us for maintaining branches: https://github.com/googleapis/release-please/blob/master/src/github.ts#L569 |
Beta Was this translation helpful? Give feedback.
-
It's still marked as TODO, so maybe you just haven't recently run into conflicts as you said... |
Beta Was this translation helpful? Give feedback.
-
if you could create a script that reproduces the problem, I'd be happy to look into it myself, too. It sounds like a common-enough use case to create a reusable plugin for |
Beta Was this translation helpful? Give feedback.
-
It's basically GitHub that closes PRs with zero changes (which happens when updating to HEAD). A repro script will just include updateRef with the target commit HEAD and force:true. You can also do the same in CLI: What I need is: an atomic API to 1. do the above and 2. and also |
Beta Was this translation helpful? Give feedback.
-
I have a similar use case. Here's my workaround adapted for this scenario:
|
Beta Was this translation helpful? Give feedback.
-
I want to push a merge commit where the conflicting files are rewritten by the tool.
Background:
I have a tool named
webidl-updater
to read Web IDL from web specifications and send pull requests to modify their syntax problems automatically.The PRs frequently get merge conflicts since the specs are being actively updated, but there is no way to solve the conflicts solely with Octokit REST API.
Currently the tool just opens a new PR whenever conflict happens, which is suboptimal. (See w3c/csswg-drafts#4385 and w3c/csswg-drafts#4798.)
Beta Was this translation helpful? Give feedback.
All reactions