From a2db313476f801985b4c46f664b7ce2781d9f652 Mon Sep 17 00:00:00 2001 From: wolfy1339 Date: Tue, 19 Nov 2024 19:07:08 -0500 Subject: [PATCH] fix: remove `@types/node` from generated types See https://github.com/octokit/octokit.js/issues/2762#issuecomment-2486997620 --- package-lock.json | 21 +++++++++------------ package.json | 1 - tsconfig.json | 3 ++- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1eb4063b4..10e8cf4de 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13,7 +13,6 @@ }, "devDependencies": { "@octokit/tsconfig": "^4.0.0", - "@types/node": ">= 8", "github-openapi-graphql-query": "^4.0.0", "handlebars": "^4.7.6", "npm-run-all2": "^7.0.0", @@ -3372,16 +3371,16 @@ } }, "node_modules/npm-run-all2": { - "version": "7.0.0", - "resolved": "https://registry.npmjs.org/npm-run-all2/-/npm-run-all2-7.0.0.tgz", - "integrity": "sha512-hXQT0BFU0G37H516ZJgISho4FslbdqMj7U8A7xoj81mhYSyxnwfF6dsraWAA1xL7ak/8yUVvAN4Lx4PpTc5Ohg==", + "version": "7.0.1", + "resolved": "https://registry.npmjs.org/npm-run-all2/-/npm-run-all2-7.0.1.tgz", + "integrity": "sha512-Adbv+bJQ8UTAM03rRODqrO5cx0YU5KCG2CvHtSURiadvdTjjgGJXdbc1oQ9CXBh9dnGfHSoSB1Web/0Dzp6kOQ==", "dev": true, "license": "MIT", "dependencies": { "ansi-styles": "^6.2.1", "cross-spawn": "^7.0.3", "memorystream": "^0.3.1", - "minimatch": "^10.0.1", + "minimatch": "^9.0.0", "pidtree": "^0.6.0", "read-package-json-fast": "^4.0.0", "shell-quote": "^1.7.3", @@ -3394,7 +3393,7 @@ "run-s": "bin/run-s/index.js" }, "engines": { - "node": "^20.5.0 || >=22.0.0", + "node": "^18.17.0 || >=20.5.0", "npm": ">= 9" } }, @@ -3403,7 +3402,6 @@ "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz", "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==", "dev": true, - "license": "MIT", "dependencies": { "balanced-match": "^1.0.0" } @@ -3419,16 +3417,15 @@ } }, "node_modules/npm-run-all2/node_modules/minimatch": { - "version": "10.0.1", - "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-10.0.1.tgz", - "integrity": "sha512-ethXTt3SGGR+95gudmqJ1eNhRO7eGEGIgYA9vnPatK4/etz2MEVDno5GMCibdMTuBMyElzIlgxMna3K94XDIDQ==", + "version": "9.0.4", + "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-9.0.4.tgz", + "integrity": "sha512-KqWh+VchfxcMNRAJjj2tnsSJdNbHsVgnkBhTNrW7AjVo6OvLtxw8zfT9oLw1JSohlFzJ8jCoTgaoXvJ+kHt6fw==", "dev": true, - "license": "ISC", "dependencies": { "brace-expansion": "^2.0.1" }, "engines": { - "node": "20 || >=22" + "node": ">=16 || 14 >=14.17" }, "funding": { "url": "https://github.com/sponsors/isaacs" diff --git a/package.json b/package.json index c51fb6e86..252e3d801 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,6 @@ "license": "MIT", "devDependencies": { "@octokit/tsconfig": "^4.0.0", - "@types/node": ">= 8", "github-openapi-graphql-query": "^4.0.0", "handlebars": "^4.7.6", "npm-run-all2": "^7.0.0", diff --git a/tsconfig.json b/tsconfig.json index b8bf46ad8..ef96bed06 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,7 +6,8 @@ "outDir": "pkg/dist-types", "emitDeclarationOnly": true, "sourceMap": true, - "verbatimModuleSyntax": false + "verbatimModuleSyntax": false, + "lib": ["es2022", "dom"] }, "include": [ "src/**/*"