Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT]: Release is failing #862

Closed
1 task done
gr2m opened this issue Nov 13, 2023 · 4 comments · Fixed by #863
Closed
1 task done

[MAINT]: Release is failing #862

gr2m opened this issue Nov 13, 2023 · 4 comments · Fixed by #863
Assignees
@wolfy1339
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@gr2m
Copy link
Contributor

gr2m commented Nov 13, 2023

Describe the need

ts-node --esm -T bin/octokit-schema.mts

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".mts" for /home/runner/work/webhooks/webhooks/bin/octokit-schema.mts

https://github.com/octokit/webhooks/actions/runs/6845309525/job/18610328638#step:5:9

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@gr2m gr2m added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Nov 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 self-assigned this Nov 13, 2023
@wolfy1339 wolfy1339 removed the Status: Triage This is being looked at and prioritized label Nov 13, 2023
@wolfy1339
Copy link
Member

I'll look into this

@wolfy1339
Copy link
Member

This is a known issue with NodeJS 20 and ts-node
TypeStrong/ts-node#1997

@nickfloyd nickfloyd moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active Nov 13, 2023
wolfy1339 added a commit that referenced this issue Nov 13, 2023
@wolfy1339
build: fix scripts Node 20 compat
f1e046b 
This is an issue with how ts-node hooks into the import process due to a breaking change made in NodeJS 20
See TypeStrong/ts-node#1997 for more details

Fixes #862
@wolfy1339 wolfy1339 mentioned this issue Nov 13, 2023
Merged
4 tasks
wolfy1339 added a commit that referenced this issue Nov 13, 2023
@wolfy1339
build: fix scripts Node 20 compat (#863)
f990247 
This is an issue with how ts-node hooks into the import process due to a breaking change made in NodeJS 20
See TypeStrong/ts-node#1997 for more details

Fixes #862
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Nov 13, 2023
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 7.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfy1339 wolfy1339

Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: fix scripts Node 20 compat octokit/webhooks
3 participants
@gr2m @wolfy1339 @octokitbot