Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "companyId" field needs to be removed. #64

Closed
Sddilora opened this issue May 15, 2024 · 3 comments · Fixed by #91
Closed

The "companyId" field needs to be removed. #64

Sddilora opened this issue May 15, 2024 · 3 comments · Fixed by #91
Assignees
@arzuups
Labels
Be compliance Ensuring adherence to standards and regulations fix Identification and resolution of bugs low priority Minor issues, can be addressed later

Comments

@Sddilora
Copy link
Member

op-be-user/internal/domain/model/entity/userfilter.go

Line 37 in 4fe7b23

compnayId uuid.UUID,

The "companyId" field needs to be removed from "NewUserFilter" func
@Sddilora Sddilora added low priority Minor issues, can be addressed later fix Identification and resolution of bugs compliance Ensuring adherence to standards and regulations labels May 16, 2024
@arzuups
Copy link
Member

arzuups commented May 17, 2024

I removed companyId field.

@Sddilora
Copy link
Member Author

you need to create a pull request from your fork

@Sddilora
Copy link
Member Author

oh sorry, I have reviewed the PR and added a comment to it.

@arzuups arzuups mentioned this issue May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arzuups arzuups

Labels
Be compliance Ensuring adherence to standards and regulations fix Identification and resolution of bugs low priority Minor issues, can be addressed later
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compnayId field removed arzuups/op-be-user
3 participants
@arzuups @Sddilora @octopos-prime