Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherent number formatting #381

Open
art-w opened this issue Aug 23, 2022 · 0 comments
Open

Coherent number formatting #381

art-w opened this issue Aug 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@art-w
Copy link
Contributor

art-w commented Aug 23, 2022

The PR benchmarks displays a comparison table with master that is very noisy, especially when no performance change is introduced:

cb-precision

Some ideas:

  • Fix the floating point numbers to max 2 digits of precision (with no random e-14 scientific notation introducing misalignment... but at the same time, we still need to be able to display tiny metrics!)
  • Make sure the font has a fixed size and that everything aligns nicely to ease reading (perhaps the css text-align: "." center mentioned in https://alistapart.com/article/web-typography-tables/ can be useful)
  • Add units!
  • Finally, it would be nice to reuse the work from WIP: Look for changed significantly metrics and notify authors #358 to only display the metrics that require further inspection, a big table of mostly 0.0001% hides the actually useful data.

(reported by @Leonidas-from-XIV from this example PR https://autumn.ocamllabs.io/ocaml-community/yojson/pull/152?worker=autumn&image=ocaml%2Fopam%3Adebian-11-ocaml-4.13 )

@art-w art-w added the enhancement New feature or request label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant