Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current-bench gives up testing commits on the master branch if new commits have been pushed in the meantime #436

Open
kit-ty-kate opened this issue Apr 27, 2023 · 1 comment

Comments

@kit-ty-kate
Copy link

To reproduce:

  • Merge a PR (this triggers current-bench on the merge commit)
  • While current-bench is still running, merge another PR

This will cancel the bench on the previous merge commit an leave the github status for said merge commit as "pending" for all eternity.

@punchagan
Copy link
Contributor

punchagan commented Apr 28, 2023

On PRs, cancelling the previous run may still be a good idea, but on master we still want to benchmark for those commits, I think. Leaving the status as pending is a bug, in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants