-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCamlformat version makes the analysis fail #834
Comments
I'm trying to reproduce the bug, I set ocamlformat version to "0.99.0" And I got this https://ocaml.ci.dev/github/moyodiallo/odoc/commit/28c31b974605701babfd0c645d0b8de5c68d6591 Would you like to validate it ? Or did something change ? @Julow |
This reproduces the problem: The |
The fix for this issue is deployed, would you like to validate the result observed here https://ocaml.ci.dev/github/moyodiallo/odoc/commit/28c31b974605701babfd0c645d0b8de5c68d6591 (same link as above). |
That fixes my issue, thanks :) Though the error message isn't nice:
The job might as well fail immediately with a clearer message. |
You're right, verifying if the ocamlformat version is available from the analysis result. |
Fix the analysis with unrelease ocamlformat version (#834)
Is this fixed by #865 @moyodiallo?
|
This is the fix of ocurrent#834, which was partially fixed on ocurrent#865
After the merge of #877, we can close this. |
We still observe this on ocamlformat's repository: https://github.com/ocaml-ppx/ocamlformat/runs/17517278251 (we don't have a set version in the .ocamlformat file because we use the version of the same commit to format ocamlformat's codebase) |
Keep in mind those 2 issues are different. what you're describing is ocamlformat without version. I think It could be preferable to open another issue. |
@moyodiallo you're right, I've opened another issue. |
Context
I opened PRs with the next unreleased version of OCamlformat applied. The
version
field in.ocamlformat
contains an invalid value.Step(s) to reproduce
Expected behaviour
The version of OCamlformat seems to be resolved for every compilers and every compilers fail to resolve due to that.
I would expect:
Additional context
For example, in Odoc on this PR: ocaml/odoc#979
CI result: https://ocaml.ci.dev/github/ocaml/odoc/commit/f42fd067a329da36ef64f1f2cdac75967da60885/variant/%28analysis%29
The text was updated successfully, but these errors were encountered: