Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem resolving most GW #253

Open
dsavchenko opened this issue Apr 22, 2024 · 9 comments
Open

Problem resolving most GW #253

dsavchenko opened this issue Apr 22, 2024 · 9 comments

Comments

@dsavchenko
Copy link
Member

dsavchenko commented Apr 22, 2024

GW150914 is "unknown object" in frontend. I checked by directly requesting the resolver, it resolves it well.
So the problem is probably on the frontend side. @motame @burnout87 could you help me to debug it?

Another related issue: when the object is unknown, the button "resolve" becomes inactive and will become active only if one fully clears the field and inputs again. Just editing doesn't work.

@dsavchenko dsavchenko self-assigned this Apr 22, 2024
@dsavchenko dsavchenko changed the title GW resolver stopped working Problem resolving some GW Apr 25, 2024
@dsavchenko dsavchenko transferred this issue from oda-hub/oda-resolver Apr 25, 2024
@dsavchenko dsavchenko removed their assignment Apr 25, 2024
@burnout87
Copy link
Collaborator

Found this in the mmoda log

Notice: Undefined index: use_resolver in resolve_object_name_callback() (line 426 of /var/www/mmoda/sites/all/modules/mmoda/mmoda.common.inc).

@burnout87
Copy link
Collaborator

@dsavchenko
Copy link
Member Author

BTW it seems that it is unknown

This is the first ever GW event, it should be known ;)

I don't know why this query to Simbad returns nothing. It can be found like this https://simbad.cds.unistra.fr/simbad/sim-basic?Ident=GW150914 (not very useful, though, as there is no defined coordinate, and no timing info in Simbad)
But this doesn't matter.

We have a plugin for GW which proxies the requests to gwosc.org
I can't, unfortunately, check with internal address of resolver in unige. It works by directly querying the resolver of my staging https://resolver.odahub.fr/api/v1.1/byname/GW150914 , but doesn't work in frontend there

@burnout87
Copy link
Collaborator

I can confirm that the outputs of

https://resolver-prod.obsuks1.unige.ch/api/v1.1/byname/GW150914
and
https://resolver.odahub.fr/api/v1.1/byname/GW150914

are identical. Or, again, I am missing something

@dsavchenko
Copy link
Member Author

So it's resolved, actually.
For most of GW, coordinates are not defined, what matters is time.
I was sure it used to work before in the frontend, only setting time fields, but now it doesn't (except for GW170817 which is special as it has an electromagnetic counterpart, thus fixed coordinates)

@burnout87
Copy link
Collaborator

can this be closed ? @dsavchenko

@dsavchenko
Copy link
Member Author

can this be closed ? @dsavchenko

The intended behaviour for most GW (when coordinates are undefined) is to only set T1, T2, leaving coordinates unchanged (probably, some message of what actually are set would be useful).

@dsavchenko dsavchenko changed the title Problem resolving some GW Problem resolving most GW May 2, 2024
@dsavchenko
Copy link
Member Author

dsavchenko commented May 2, 2024

BTW, @volodymyrss
I tried with GRBs to see how it works, and it seems that resolver doesn't return timing information, which looks strange to me.
Does it have to be like this?

@volodymyrss
Copy link
Member

There is not really a universal source of GRB time information.
We inserted Polar GRB table there.

I had also parser based on https://github.com/oda-hub/literature-to-facts .
We can re-enable it somehow oda-hub/oda-resolver#17 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants