Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert frontend commit version somewhere in the UI, in the footer? #255

Open
volodymyrss opened this issue May 2, 2024 · 8 comments · Fixed by #257
Open

insert frontend commit version somewhere in the UI, in the footer? #255

volodymyrss opened this issue May 2, 2024 · 8 comments · Fixed by #257
Assignees

Comments

@volodymyrss
Copy link
Member

No description provided.

@burnout87
Copy link
Collaborator

are we talking about the version, as discussed here ? oda-hub/frontend-tab-generator#35

@volodymyrss
Copy link
Member Author

are we talking about the version, as discussed here ? oda-hub/frontend-tab-generator#35

no, here I am talking about frontend version, not instrument version. Frontend version consists of version of the involved component.

@burnout87
Copy link
Collaborator

What about

image

@volodymyrss
Copy link
Member Author

looks good!

@burnout87 burnout87 linked a pull request May 6, 2024 that will close this issue
@burnout87
Copy link
Collaborator

how are you planning to update the version when there is a new deployment ?

@volodymyrss
Copy link
Member Author

it should set as an env variable, or we can introduce it into drupal instance somehow, inserting in DB. Please provide a way to set it from CLI in such a way that you can fetch it from the frontend

@volodymyrss volodymyrss reopened this Aug 27, 2024
@volodymyrss
Copy link
Member Author

Apparently it's gone now.

@burnout87
Copy link
Collaborator

this issue was about the frontend version, for the version of the specific instrument, it was here, it can be added as an arg from the tab_generator CLI:

image

The args are:

  • instrument_version
  • instrument_version_link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants