mobile and desktop invisible elements #3727
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
467dadd to
5cab1c7
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-2
branch
2 times, most recently
from
9d42d96 to
213385b
Compare
FrancoisGe
force-pushed
the
master-mysterious-egg
branch
from
18a0e98 to
58143fd
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-2
branch
5 times, most recently
from
3faebbb to
e0486d5
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-2
branch
from
e0486d5 to
fb721c4
Compare
FrancoisGe
reviewed
Dec 13, 2024
| @@ -62,7 +63,10 @@ export class SnippetsMenu extends Component { | |||
| canRedo: false, | |||
| activeTab: this.props.isTranslation ? "customize" : "blocks", | |||
| currentOptionsContainers: undefined, | |||
| }); | |||
| this.invisibleElsContext = reactive({ | |||
| invisibleEls: [], | ||
| invisibleSelector: this.invisibleSelector, |
There was a problem hiding this comment.
It s ok to compute the value invisibleSelector just at the setup ?
What happens if a value in invisibleSelector change
| useSubEnv({ | ||
| mobileContext: this.state.mobileContext, |
There was a problem hiding this comment.
Maybe overkill to pass it in the env ? Maybe wait to have a real use case ? Props is enough in this case no ?
| let nbrCall = 0; | ||
| patchWithCleanup(InvisibleElementsPanel.prototype, { | ||
| getInvisibleElementsEntries() { | ||
| nbrCall++; |
There was a problem hiding this comment.
In this type of use case, you can use expect.step :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.