Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore trait implementation in Odra module #212

Closed
kpob opened this issue Jul 19, 2023 · 0 comments · Fixed by #291
Closed

Do not ignore trait implementation in Odra module #212

kpob opened this issue Jul 19, 2023 · 0 comments · Fixed by #291
Assignees
Labels

Comments

@kpob
Copy link
Contributor

kpob commented Jul 19, 2023

At the moment, if you implement a trait for a module, the defined contract will be ignored.

trait ContractInterface {
  fn name() -> String;
}

#[odra::module]
struct Contract;

#[odra::module]
impl ContractInterface for Contract {
  fn name() -> String;
}

The expanded code would be:

impl Contract {
  fn name() -> String;
}

...
/// Deployer, Ref, etc
@kpob kpob added the macro label Jul 19, 2023
@kpob kpob added this to the Future milestone Jul 19, 2023
@zie1ony zie1ony removed this from the Future milestone Nov 28, 2023
@kpob kpob self-assigned this Dec 6, 2023
@zie1ony zie1ony moved this to 🆕 New in ⚔️Tavern 🐉 Dec 11, 2023
@zie1ony zie1ony moved this from 🆕 New to 🔖 Ready in ⚔️Tavern 🐉 Dec 11, 2023
@kpob kpob linked a pull request Dec 11, 2023 that will close this issue
@kpob kpob closed this as completed in #291 Dec 12, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in ⚔️Tavern 🐉 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants