Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: Naming and Interfaces of Load Functionality in Erc20Deployer #329

Closed
coderabbitai bot opened this issue Jan 24, 2024 · 1 comment
Closed

Discussion: Naming and Interfaces of Load Functionality in Erc20Deployer #329

coderabbitai bot opened this issue Jan 24, 2024 · 1 comment

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2024

There's a need to reconsider the naming and interfaces of the load functionality within the Erc20Deployer, as it might not be intuitive to expect load functionality in a deployer. This issue is to discuss potential improvements or alternatives.

Context:

/cc @kpob @kubaplas
@github-project-automation github-project-automation bot moved this to 🆕 Discuss in ⚔️Tavern 🐉 Jan 24, 2024
@zie1ony
Copy link
Contributor

zie1ony commented May 20, 2024

HostRef handle both functions now.

@zie1ony zie1ony closed this as completed May 20, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Discuss to ✅ Done in ⚔️Tavern 🐉 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
⚔️Tavern 🐉
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zie1ony