Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default directory for dump/restore. #49

Open
p-snft opened this issue Apr 2, 2024 · 1 comment · May be fixed by #50
Open

Change default directory for dump/restore. #49

p-snft opened this issue Apr 2, 2024 · 1 comment · May be fixed by #50

Comments

@p-snft
Copy link
Member

p-snft commented Apr 2, 2024 •
edited
Loading

Extracted from oemof/oemof-solph#1027:

There was a problem because of old dump file. Writing a new one failed for whatever reason. So, energysystem.restore() restored whatever results were already present instead of newly generated results.

I don't think that the default behavior is sensible. Why would I dump the energy system into a .oemof folder in the $Home directory? Wouldn't it make more sense to use the current working directory (os.getcwd()) or the directory of the file from which the energysystem.dump()/energysystem.restore() command was called?

Originally posted by @lensum in oemof/oemof-solph#1027 (comment)
@pieterhexen
Copy link

pieterhexen commented Apr 23, 2024 •
edited
Loading

Instead of splitting the file path into dpath and filename can there be a single argument for energysystem.dump()/energysystem.restore() like file.

Imo this would be more in line with save/dump methods of other libraries and facilitate the usage in workflow tools.

@p-snft p-snft linked a pull request May 7, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare for new dump path handling oemof/oemof-network
2 participants
@p-snft @pieterhexen