Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling period-specific parameters in multi-period-investment #959

Closed
nailend opened this issue Jul 20, 2023 · 3 comments
Closed

Handling period-specific parameters in multi-period-investment #959

nailend opened this issue Jul 20, 2023 · 3 comments

Comments

@nailend
Copy link
Contributor

nailend commented Jul 20, 2023

Dear all,

in our current project, we want to make use of period-specific parameters in a multi-period-investment. Currently, the only way to do this is passing an iterable to this parameter with values for every timestep. As we are using omeof.tabular, we could integrate a preprocessing to generate timeseries there, but we would find a oemof.solph solution more charming from user perspective.

We would like to hear your opinion about this and collect possible challenges/restrictions. The idea is to adapt _plumbing.sequence, that if a tuple or maybe dict is passed, it returns period specific values. This would change the functionality of the function fundamentally, as the length of the list would need to be known. Further, the number of timesteps per periods need to be passed. This should be optional, so that the original way is preserved.

  • Do you have any idea. how to handle this?
  • What's the best way to pass periods information?
  • Could there be any problems with detecting tuple or dict from csv? (This needs to be handled in oemof.tabular read_from_datapackage)

@jokochems, @p-snft, do you have any thoughts on this?

We are looking forward to your ideas and thank you for your help.

@jokochems
Copy link
Member

I haven't dealt with _plumbing.sequence much except for applying it. I saw your pull request and liked the additional functionality and periods mapping you put in it.

I cannot say whether this breaks anything, but I guess you are all good in case you can successfully run the tests and examples, right?!

@nailend nailend self-assigned this Aug 7, 2023
@p-snft
Copy link
Member

p-snft commented Aug 11, 2023

If it's okay, I'd like to finish v0.5.1 before concentrating on this. (We can have v0.5.2.dev0 directly afterwards, if you like.)

@nailend
Copy link
Contributor Author

nailend commented Oct 12, 2023

We decided to solve this in oemof.tabular as this approach comes with more difficulties then expected...

@nailend nailend closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants