Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrapper to enhance info on failed facade creation #145

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add wrapper to enhance info on failed facade creation #145

wants to merge 4 commits into from

Conversation

nailend
Copy link
Collaborator

@nailend nailend commented Nov 30, 2023 •
edited
Loading

Description

This wrapper catches errors while creating the facade in the reading module. This way, at least some information on which facade failed and where to look in the data are supplied.

Type of change

Please tick or delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added new features/fixes to the CHANGELOG

@nailend nailend self-assigned this Dec 4, 2023
@nailend nailend added the enhancement New feature or request label Dec 4, 2023
@nailend nailend requested a review from henhuy December 5, 2023 15:14
@nailend
Copy link
Collaborator Author

nailend commented Dec 15, 2023

@henhuy The only way to test this is by providing a false datapackage. I already had this before in #134. Do you think it makes sense to add one to the tests?

@henhuy
Copy link
Collaborator

henhuy commented Dec 15, 2023

@henhuy The only way to test this is by providing a false datapackage. I already had this before in #134. Do you think it makes sense to add one to the tests?

I think this would be helpful indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henhuy henhuy Awaiting requested review from henhuy

Assignees

@nailend nailend

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nailend @henhuy