Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment stripping and apply when parsing cell/param files #173

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

oerc0122
Copy link
Owner

@oerc0122 oerc0122 commented Oct 1, 2024

Add comment stripping and apply when parsing .cell/.geom blocks.

@oerc0122 oerc0122 added the enhancement New feature or request label Oct 1, 2024
@oerc0122 oerc0122 requested a review from ajjackson October 1, 2024 15:07
@oerc0122 oerc0122 self-assigned this Oct 1, 2024
Copy link
Collaborator

@ajjackson ajjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty nice! A few queries.

castep_outputs/utilities/utility.py Outdated Show resolved Hide resolved
castep_outputs/utilities/utility.py Show resolved Hide resolved
castep_outputs/utilities/utility.py Outdated Show resolved Hide resolved
castep_outputs/utilities/utility.py Show resolved Hide resolved
castep_outputs/utilities/utility.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ajjackson ajjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oerc0122 oerc0122 merged commit 5899c35 into main Oct 2, 2024
5 checks passed
@oerc0122 oerc0122 deleted the comment-strip branch October 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants