Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some miscellaneous issues breaking expectations/tests #177

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

oerc0122
Copy link
Owner

@oerc0122 oerc0122 commented Nov 28, 2024

  • Accidentally labelled parse_args empty example as doctest causing failure with pytest --doctest-modules
  • Force output to Path for required method in parse_single
  • Make Block.get_lines add lines as elements of tuple rather than as characters.
  • Fix issue with latest ruff version.
  • Pin ruff version to avoid this problem in future

@oerc0122 oerc0122 added the bug Something isn't working label Nov 28, 2024
@oerc0122 oerc0122 requested a review from ajjackson November 28, 2024 15:22
@oerc0122 oerc0122 self-assigned this Nov 28, 2024
Copy link
Collaborator

@ajjackson ajjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem fine and I don't mind them being batched as they are small and non-interactive.

Pinning an exact ruff version seems a bit aggressive, but I suppose as developers are not obliged to use the [lint] extra locally it's not the end of the world.

@oerc0122 oerc0122 merged commit 5c54af4 into main Nov 29, 2024
5 checks passed
@oerc0122 oerc0122 deleted the fix-misc-issues branch November 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants