From 82aa0c4cd1de2da5001c9d46f3222de87328886f Mon Sep 17 00:00:00 2001 From: Bradley Dice Date: Thu, 2 May 2024 14:03:17 -0700 Subject: [PATCH] Remove .gitmodules. (#9674) Summary: It appears that git submodules are no longer used in this repository, as `gtest` and `xsimd` were moved to `resolve_dependency` in https://github.com/facebookincubator/velox/pull/4218. However, the `.gitmodules` file still exists. I think this file is safe to remove now. Pull Request resolved: https://github.com/facebookincubator/velox/pull/9674 Reviewed By: Yuhta Differential Revision: D56791639 Pulled By: kgpai fbshipit-source-id: 78bb4d530340c6bbd0e4c126090a34cda39cebb2 --- .gitmodules | 6 ------ README.md | 13 +++++-------- 2 files changed, 5 insertions(+), 14 deletions(-) delete mode 100644 .gitmodules diff --git a/.gitmodules b/.gitmodules deleted file mode 100644 index c4d716cbc4f5..000000000000 --- a/.gitmodules +++ /dev/null @@ -1,6 +0,0 @@ -[submodule "third_party/googletest"] - path = third_party/googletest - url = https://github.com/google/googletest.git -[submodule "third_party/xsimd"] - path = third_party/xsimd - url = https://github.com/xtensor-stack/xsimd.git diff --git a/README.md b/README.md index 69fd642a1d38..3e1dbc3cade3 100644 --- a/README.md +++ b/README.md @@ -72,11 +72,8 @@ Blog posts are available [here](https://velox-lib.io/blog). ### Get the Velox Source ``` -git clone --recursive https://github.com/facebookincubator/velox.git +git clone https://github.com/facebookincubator/velox.git cd velox -# if you are updating an existing checkout -git submodule sync --recursive -git submodule update --init --recursive ``` Once Velox is checked out, the first step is to install the dependencies. Details on the dependencies and how Velox manages some of them for you @@ -90,7 +87,7 @@ dependencies for a given platform. On an Intel MacOS machine you can setup and then build like so: ```shell -$ ./scripts/setup-macos.sh +$ ./scripts/setup-macos.sh $ make ``` @@ -117,7 +114,7 @@ $ CPU_TARGET="aarch64" make Once you have checked out Velox, you can setup and build like so: ```shell -$ ./scripts/setup-ubuntu.sh +$ ./scripts/setup-ubuntu.sh $ make ``` @@ -135,7 +132,7 @@ Note that, * f16c * Velox tries to use the following (or equivalent) instruction sets where available: * On Intel CPUs - * avx + * avx * avx2 * sse * On ARM @@ -167,7 +164,7 @@ contribute to the project. ## Community The main communication channel with the Velox OSS community is through the -[the Velox-OSS Slack workspace](http://velox-oss.slack.com). +[the Velox-OSS Slack workspace](http://velox-oss.slack.com). Please reach out to **velox@meta.com** to get access to Velox Slack Channel.