Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contentfilter container image #63

Open
kelson42 opened this issue Jun 8, 2022 · 12 comments
Open

Add contentfilter container image #63

kelson42 opened this issue Jun 8, 2022 · 12 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@kelson42
Copy link
Contributor

kelson42 commented Jun 8, 2022

This is necessary to create images for Bard.

Kind of follower of offspot/kiwix-hotspot#613.

@rgaudin
Copy link
Member

rgaudin commented Jun 8, 2022

Wouldn't this be part of our project.json ? Unless necessary, I suggest we keep our kiwix-related tickets that don't affect the creator outside this repository

@kelson42
Copy link
Contributor Author

kelson42 commented Jun 8, 2022

@rgaudin I don't expect random container images to work out-of-the box with image-creator because (at least):

  • Image should fullfill a few requirements (still to be defined)
  • Things should be tested
  • Catalogue should be updated
  • Here it would deal with the reverse proxy, so some kind of integration work is probably necessary
  • If implemented, might be harder/not a good idea to have this only for a subset of apps.

This is why, I have put it here first. Like a few other containers (for example the captive portal, reverse proxy, ...), both orgs might use it.

What would be concretly a better place? Offspot/content-filter?

@rgaudin
Copy link
Member

rgaudin commented Jun 8, 2022

image-creator is a software for building the image. What you are mentioning is all very important but that's part of the solution, not the creator. There will be zero code about this in this repo (some might require tighter integration, most likely at base-image level) so issues about those should not pollute this repo.

We should to discuss whether we want a single repo to share code and issues about all those pieces and/or/if we need an overview one as well.

@rgaudin rgaudin transferred this issue from offspot/image-creator Oct 14, 2022
@rgaudin rgaudin changed the title Integrate offspot/content-filter Add contentfilter image Oct 14, 2022
@rgaudin rgaudin added the question Further information is requested label Oct 14, 2022
@rgaudin
Copy link
Member

rgaudin commented Oct 14, 2022

Now that bard has shipped and we know it won't reconcile its codebase, is this image/feature still relevant generally ? Precisely: should we implement this? drop it? implement it later?

@kelson42
Copy link
Contributor Author

kelson42 commented Oct 14, 2022

@rgaudin It's important we maintain it IMO and provide it as (optional?) tool in the imager.

@kelson42
Copy link
Contributor Author

@rgaudin It's strategic for Kiwix that this tool is available, better soon than later, in Kiwix Hotspot. The reason is that we need to it, to remove the duty of censorhip of the shoulders of Kiwix.

@kelson42 kelson42 transferred this issue from offspot/container-images May 26, 2024
@kelson42
Copy link
Contributor Author

@rgaudin I suspect this issue can be closed?

@rgaudin
Copy link
Member

rgaudin commented May 26, 2024

There is an image but it's not working. It's just the bard code and it requires both work on the image and in the proxy configuration to make it work.
I found it well located at container-images for that reason

@kelson42
Copy link
Contributor Author

@rgaudin How much additional work would be needed to have it as proper feature?
@Popolechien To me it would be really nice to have this in the feature set... but not sure about the priority

@kelson42 kelson42 transferred this issue from offspot/content-filter May 26, 2024
@kelson42 kelson42 changed the title Add contentfilter image Add contentfilter container image May 26, 2024
@rgaudin
Copy link
Member

rgaudin commented May 27, 2024

I'd say 1d ± .5d

@Popolechien
Copy link

Honestly to me it is super-low priority. There's no actual demand for it atm. I'd file it under "nice to have".

@kelson42
Copy link
Contributor Author

My main concern is having work done not reaching end-users. I would propose to:

  • Count it as feature (and advert it)
  • if anybody complains or ask about it, then complete quickly the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants