Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate unmigrated styles to dark theme #191

Open
shivankacker opened this issue Mar 9, 2024 · 8 comments
Open

Migrate unmigrated styles to dark theme #191

shivankacker opened this issue Mar 9, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@shivankacker
Copy link
Member

shivankacker commented Mar 9, 2024

With the addition of our new Dark Theme, we have implemented special classes that substitute to relative colors depending on Theme.

for example, bg-primary substitutes to bg-white in white mode and bg-black in dark mode.

A list of all the relative colors are present in constants.

We have to migrate unmigrated pages to these new classes. Majorly in the Admin Panel.

@shivankacker shivankacker added the good first issue Good for newcomers label Mar 9, 2024
@vishisht-dubey
Copy link
Contributor

@skks1212 assign me this
also i would implement this modal change
from this
Screenshot 2024-03-09 193736
to this
Screenshot 2024-03-09 194118
is it ok??

@Ashesh3
Copy link
Member

Ashesh3 commented Mar 11, 2024

@skks1212 assign me this also i would implement this modal change from this Screenshot 2024-03-09 193736 to this Screenshot 2024-03-09 194118 is it ok??

This change looks fine. Just make sure it looks fine in light mode too.

@vishisht-dubey
Copy link
Contributor

@skks1212 assign me this also i would implement this modal change from this Screenshot 2024-03-09 193736 to this Screenshot 2024-03-09 194118 is it ok??

This change looks fine. Just make sure it looks fine in light mode too.

sure

@vishisht-dubey
Copy link
Contributor

@skks1212 @Ashesh3 i was not able to figure out why dark:bg-[some_color] when i am applying this in className it is not working as it should work can you please check??
also in tailwind.config.js module.exports:{darkMode:'media' ...} can we add this as it is used when we work with both light and dark mode, any suggestion??

@shivankacker
Copy link
Member Author

@vishisht-dubey Our implementation of dark mode is different. We don't use the dark: class because it results in a lot of manual class rewrites.
Rather, we use relative class names that produce different results for each mode.

for example, bg-primary substitutes to bg-white in white mode and bg-black in dark mode.

A list of all the relative colors are present in constants.

@vishisht-dubey
Copy link
Contributor

Hii @skks1212 i have done all the changes just want your suggestion
How about introducing theme toggle button in adminSidebar
Screenshot 2024-03-13 184426
should i do this ?? what are your opinions??

@vishisht-dubey
Copy link
Contributor

Hii @skks1212 #191 this is the linked pr

@shivankacker
Copy link
Member Author

Hii @skks1212 i have done all the changes just want your suggestion How about introducing theme toggle button in adminSidebar

Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants