Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added “modified_date” & “updated_by” to the User table #2085 #2106

Closed
wants to merge 0 commits into from
Closed

Added “modified_date” & “updated_by” to the User table #2085 #2106

wants to merge 0 commits into from

Conversation

ayushchauhan12
Copy link
Contributor

@ayushchauhan12 ayushchauhan12 commented Apr 21, 2024 •
edited
Loading

Proposed Changes

  • Added “modified_date” & “updated_by” to the User table for tracking updates made by admins

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Screenshots
Screenshot 2024-04-21 230936

@ayushchauhan12 ayushchauhan12 requested a review from a team as a code owner April 21, 2024 14:32
sainak
sainak requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete and recreate the migrations, instead of using a middleware use the serializer/viewset

@ayushchauhan12
Copy link
Contributor Author

okay working on it

@ayushchauhan12
Copy link
Contributor Author

@sainak but using serializers/viewset in models will create circular import error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add “modified_date” & “updated_by” to the User table
2 participants
@ayushchauhan12 @sainak