Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash #6006

Closed
Tracked by #6004
sainak opened this issue Aug 4, 2023 · 14 comments · Fixed by #9116
Closed
Tracked by #6004

remove lodash #6006

sainak opened this issue Aug 4, 2023 · 14 comments · Fixed by #9116
Assignees
Labels

Comments

@sainak
Copy link
Member

sainak commented Aug 4, 2023

No description provided.

@sainak sainak mentioned this issue Aug 4, 2023
13 tasks
@github-project-automation github-project-automation bot moved this to Triage in Care Aug 4, 2023
@sainak sainak changed the title remove lodash saves 540Kb remove lodash Aug 4, 2023
@sainak sainak self-assigned this Aug 4, 2023
@nihal467 nihal467 moved this from Triage to In Progress in Care Aug 8, 2023
@nihal467 nihal467 moved this from In Progress to Up Next in Care Aug 8, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Aug 19, 2023
@sainak sainak removed the stale label Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Oct 4, 2023
Omkar76 added a commit to Omkar76/care_fe that referenced this issue Oct 6, 2023
mathew-alex added a commit that referenced this issue Oct 18, 2023
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Oct 18, 2023
@rithviknishad
Copy link
Member

Keeping the issue opened, as loadash was not removed and only replaced in previous PR

@rithviknishad rithviknishad reopened this Oct 18, 2023
@rithviknishad rithviknishad moved this from Done to Up Next in Care Oct 18, 2023
Ashesh3 pushed a commit that referenced this issue Oct 20, 2023
Ashesh3 pushed a commit that referenced this issue Oct 23, 2023
@Ashesh3
Copy link
Member

Ashesh3 commented Dec 5, 2023

@sainak are you still working on this?

@tellmeY18
Copy link
Member

@gigincg

@gigincg gigincg assigned tellmeY18 and unassigned sainak Sep 6, 2024
@tellmeY18 tellmeY18 moved this from Up Next to In Progress in Care Sep 9, 2024
@SwanandBhuskute
Copy link
Contributor

@rithviknishad @nihal467 pls assign me this issue

@SwanandBhuskute
Copy link
Contributor

@tellmeY18 @nihal467 @rithviknishad so here

  • i have to uninstall the "lodash-es": "^4.17.21", package
  • then remove the respective imports from all the files
  • and replace the lodash methods with some alternatives
  • like
    • in file src/Utils/Notifications.js
    • we have - import { camelCase, startCase } from "lodash-es";
    • so by removing this import , i should replace the code for its method
    • make custom methods like
    • Image

and similar in other files

is my approach right?

@github-actions github-actions bot added needs-triage question Further information is requested labels Nov 14, 2024
@rithviknishad
Copy link
Member

Yup!

For casing changes specifically, I'd suggest refactoring the usages to use tailwind's text transform classes instead of JS wherever possible.

@rithviknishad rithviknishad removed question Further information is requested needs-triage work-in-progress labels Nov 14, 2024
@SwanandBhuskute
Copy link
Contributor

ok understood @rithviknishad

@SwanandBhuskute
Copy link
Contributor

SwanandBhuskute commented Nov 14, 2024

@rithviknishad @tellmeY18 @nihal467 I have removed all the lodash imports and used custom js functions / properties

but these two files

  • bom.json
  • fe-sbom.json

has too many lodash occurences

so now
after uninstalling lodash from the project

how should i handle these two files?

@github-actions github-actions bot added needs-triage question Further information is requested labels Nov 14, 2024
@tellmeY18
Copy link
Member

Hey, the bom.json and fe-sbom.json are autogenerated via a workflow which is listing out the dependencies used in care and care_fe. you can ignore the occurance of lodash inside these 2 files and once it's completely removed from the project we should be able to generate jsons that doesn't have lodash occurences.

@tellmeY18 tellmeY18 removed question Further information is requested needs-triage labels Nov 14, 2024
@SwanandBhuskute
Copy link
Contributor

Hey, the bom.json and fe-sbom.json are autogenerated via a workflow which is listing out the dependencies used in care and care_fe. you can ignore the occurance of lodash inside these 2 files and once it's completely removed from the project we should be able to generate jsons that doesn't have lodash occurences.

oh okay, then I will just raise PR

@github-actions github-actions bot added needs-triage question Further information is requested labels Nov 14, 2024
@SwanandBhuskute
Copy link
Contributor

@tellmeY18 @rithviknishad @nihal467
hey after running npm run build
i got this log

Image

@sainak sainak moved this from Up Next to In Progress in Care Nov 15, 2024
@nihal467 nihal467 removed question Further information is requested needs-triage labels Nov 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Care Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants