Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the NIBP display from last 30 mins to current bed assignment date #6479

Merged
merged 19 commits into from
Nov 7, 2023

Conversation

sriharsh05
Copy link
Contributor

@sriharsh05 sriharsh05 commented Oct 20, 2023

WHAT

🤖 Generated by Copilot at 8c5f324

This pull request adds the feature to show the blood pressure data from the HL7 vitals monitor for a consultation, based on the bed assignment history. It modifies the HL7PatientVitalsMonitor component, the api and models files, and the ConsultationUpdatesTab component. It also updates the ChannelOptions interface to include the consultationId property.
Changed the NIPB display in vitals monitor. It was showing only if the NIBP was measured 30 mins from current time. Now Changed it to display the measured NIBP from the current bed assignment date.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 8c5f324

  • Add consultationId prop to HL7PatientVitalsMonitor component and use it to fetch and display the bed assignment history for the consultation (link, link, link, link, link, link, link, link)
  • Define consultation bed request and response interfaces in models.tsx file (link)

@sriharsh05 sriharsh05 requested a review from a team October 20, 2023 17:19
@sriharsh05 sriharsh05 requested a review from a team as a code owner October 20, 2023 17:19
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 7:42am

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0535375
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6549ea2f12e50a00071ab6f5
😎 Deploy Preview https://deploy-preview-6479--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in middleware is also required right?

src/Components/Facility/models.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/HL7PatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/HL7PatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/HL7PatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
@rithviknishad rithviknishad added changes required merge conflict pull requests with merge conflict labels Oct 22, 2023
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 23, 2023
src/Components/Facility/models.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/types.ts Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/HL7PatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
@sriharsh05
Copy link
Contributor Author

hey @rithviknishad
I have implemented the changes you requested. Can you review it please?

src/Redux/api.tsx Outdated Show resolved Hide resolved
src/Components/VitalsMonitor/HL7PatientVitalsMonitor.tsx Outdated Show resolved Hide resolved
src/Components/Facility/models.tsx Outdated Show resolved Hide resolved
src/Components/Facility/models.tsx Outdated Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour should be present for central nursing station too

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 31, 2023
@github-actions
Copy link

👋 Hi, @sriharsh05,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sriharsh05
Copy link
Contributor Author

sriharsh05 commented Nov 1, 2023

@nihal467
I have made the required changes. Now the patients NIBP data is reflecting in the patient consultation page.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Nov 3, 2023
@sriharsh05
Copy link
Contributor Author

@rithviknishad
I have made the changes you requested.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Very clean!

@rithviknishad
Copy link
Member

@sriharsh05 the issue also mentions changes to be made to the middleware too. Are you working on it?

@nihal467
Copy link
Member

nihal467 commented Nov 7, 2023

LGTM

@sriharsh05
Copy link
Contributor Author

@sriharsh05 the issue also mentions changes to be made to the middleware too. Are you working on it?

@rithviknishad I have not yet started working on it.

@khavinshankar khavinshankar merged commit e8091bf into ohcnetwork:develop Nov 7, 2023
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitals Monitor - NIBP: Only show if data is later than the current bed's assigned start date
4 participants