-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Bed Capacity Cards #6925
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 failed test on run #1812 ↗︎
Details:
cypress/e2e/patient_spec/patient_crud.cy.ts • 1 failed test
Review all test suite changes for PR #6925 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also change this to use useQuery
while we have anyways refactored the BedTypeCard component?
Yep, that'll be good. I've made the changes. |
@Ashesh3 we should be thinking about a replacement for the refresh button |
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
09e5c90
to
19d0aa9
Compare
@Ashesh3 i believe we discussed replacing the icon with the percentage of bed usage or something more value adding |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of request
, useQuery
has support for managing loading states and auto refetching, but this is fine for now since we have migrated away from redux in this PR and it works.
cc: @Ashesh3
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Fixes #6620
This pull request includes a redesign of the bed capacity cards in the FacilityBedCapacity component. The changes include adding a reverse-spin animation and adjusting the layout of the cards.
Referenced Figma Design
Design in the PR