Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the access of a district admin in respect to list of users #7500

Closed
kabirrajsingh opened this issue Mar 31, 2024 · 6 comments
Closed

Comments

@kabirrajsingh
Copy link
Contributor

#needs-discussion

Currently a district admin has access to view all the users from the users tab.
But he/she cannot perform any function on it if the user is not from his own district, basically cannot utilize the Linked facility, Linked Skills and set weekly average hours button. When he tries to perform such an operation, it gives an error from the backend but this issue could be handled better.
Suggested changes-

  1. Option 1: Does a district admin need to have even view access to users from other districts? We can restrict the view access to only users within the own district.
  2. Option 2: If the view access is provided, the users can be segregrated by adding 2 seperate tabs (My district, Other districts). The users on these tabs could be handled seperately. The action buttons would only be visible for users under my district tab.
  3. Option 3: Do not make seperate tabs and just hide the action buttons for users outside the district.

Solving this issue would also solve #7497 .
This could also be extended to solve #7374
Screenshot_15

@coronasafe/code-reviewers

@Sulochan-khadka
Copy link
Contributor

Actually I as well encountered the issue, but am not sure whether this is an actual issue or some role-based feature.
It would be better if @rithviknishad confirm this...

@Sulochan-khadka
Copy link
Contributor

@kabirrajsingh if your PR solves multiple issues, then I guess you should go ahead with my issue as well... But first get the conformation .

@kabirrajsingh
Copy link
Contributor Author

kabirrajsingh commented Mar 31, 2024

@Sulochan-khadka it is actually a restriction on the basis of District, I raised the issue in the last standup. A district admin can only use the action buttons in his own district, which in this case is Thiruvananthapuram. When you try to use it on user from another district like Ernakulam, it would throw an error. We can work on this together but the issue needs discussion first as to which approach would be the best to solve it.

@Sulochan-khadka
Copy link
Contributor

@kabirrajsingh Yeah I guess this issue will be addressed once it comes to the attention of the contributors.

Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 16, 2024
@nihal467 nihal467 added the P2 label Apr 27, 2024
@github-actions github-actions bot removed the stale label Apr 28, 2024
@nihal467
Copy link
Member

the issue has been already handled in the ohcnetwork/care#1742

@github-project-automation github-project-automation bot moved this from Triage to Done in Care May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants