Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the existing AutocompleteFormField component #7849

Closed
nihal467 opened this issue May 17, 2024 · 13 comments · Fixed by #8414
Closed

Enhance the existing AutocompleteFormField component #7849

nihal467 opened this issue May 17, 2024 · 13 comments · Fixed by #8414
Assignees

Comments

@nihal467
Copy link
Member

nihal467 commented May 17, 2024

Is your feature request related to a problem? Please describe.

When we click on a component, such as the occupation input field in the patient registration form, it does not prefetch the entire list unless the user inputs a character.

image

Describe the solution you'd like

When the user clicks on the component, it should prefetch the entire list, and the dropdown should appear as shown in the screenshot below.

Note: it should filter the dropdown based on user input incase user type anything in the component

image

@609harsh
Copy link
Contributor

@rithviknishad please assign this issue to me

@nihal467
Copy link
Member Author

nihal467 commented May 18, 2024

@609harsh I am unassigning you from this issue, as you already have an unfinished PR pending Cypress changes. Kindly work on that PR, before getting new issues assigned

@JOSHIK27
Copy link
Contributor

I would like to take up this issue. Can you assign me @rithviknishad

@JOSHIK27
Copy link
Contributor

proof.mp4

@nihal467 The requested feature can be achieved by adding a prop to the combo box headless UI component (Latest). For that, we will have to install this updated headless UI package. I have added a demo. Please let me know if this solution is ok, happy to open PR.

@rithviknishad
Copy link
Member

@JOSHIK27 Yes go ahead!

You could use #7840 as the base branch as that upgrades headless UI to the required version.

cc: @khavinshankar

@JOSHIK27
Copy link
Contributor

JOSHIK27 commented May 22, 2024

@rithviknishad I am getting conflicts when rebasing my branch with develop branch to open pr (when worked with #7840 as base branch). I will open pr once conflict is resolved.

Copy link

github-actions bot commented Jun 6, 2024

Hi, @coronasafe/care-frontend-maintainers, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Jun 6, 2024
@gigincg
Copy link
Member

gigincg commented Aug 5, 2024

@JOSHIK27 Will you be able to work on this? #7840 Has been merged.

@JOSHIK27
Copy link
Contributor

JOSHIK27 commented Aug 5, 2024

@JOSHIK27 Will you be able to work on this? #7840 Has been merged.

Yes I can. But the pr #7840 is still open. I have set up the project again, still it is using the older version of headless ui.

@gigincg gigincg removed the stale label Aug 12, 2024
@gigincg
Copy link
Member

gigincg commented Aug 12, 2024

@nihal467 Update here once HeadlessUI v2 is merged

@nihal467
Copy link
Member Author

@gigincg the migration to headless v2 PR is still in not completed, so for proper triaging purpose assigning it to you

@nihal467
Copy link
Member Author

@JOSHIK27 the headless UI is merged,

cc: @gigincg

@JOSHIK27
Copy link
Contributor

Here's the pr @nihal467 #8414

@rithviknishad rithviknishad moved this from Up Next to In Progress in Care Aug 23, 2024
@bodhish bodhish moved this from In Progress to Review required in Care Sep 2, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants