Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort button width #7958

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix sort button width #7958

merged 2 commits into from
Jun 5, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jun 2, 2024

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner June 2, 2024 22:30
Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 4:29pm

Copy link

netlify bot commented Jun 2, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c1347b8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/665def31e60d7a00098da838
😎 Deploy Preview https://deploy-preview-7958--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 2, 2024

1 failed test on run #2688 ↗︎

1 123 0 0 Flakiness 0

Details:

Fix sort button width
Project: CARE Commit: c1347b83b1
Status: Failed Duration: 03:53 💡
Started: Jun 3, 2024 6:12 PM Ended: Jun 3, 2024 6:16 PM
Failed  cypress/e2e/patient_spec/patient_consultation.cy.ts • 1 failed test • UI-Chrome

View Output

Test Artifacts
Patient Consultation in multiple combination > Internal Transfer within facility Patient with Domicilary Care Test Replay Screenshots

Review all test suite changes for PR #7958 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2024

LGTM

@khavinshankar khavinshankar merged commit 0047765 into develop Jun 5, 2024
60 of 62 checks passed
@khavinshankar khavinshankar deleted the fix-button-widths branch June 5, 2024 12:52
Copy link

github-actions bot commented Jun 5, 2024

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIsual Bug: Issue in responsiveness
3 participants