Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement to the prescrition print module #8275

Closed
1 of 4 tasks
nihal467 opened this issue Aug 8, 2024 · 8 comments · Fixed by #8704
Closed
1 of 4 tasks

Enhancement to the prescrition print module #8275

nihal467 opened this issue Aug 8, 2024 · 8 comments · Fixed by #8704
Assignees
Labels
enhancement New feature or request

Comments

@nihal467
Copy link
Member

nihal467 commented Aug 8, 2024

follow-up : #8259

Is your feature request related to a problem? Please describe.

  • currently the print button is not properly placed, seem like the button is on one corner of the page.
  • we are having multiple scroll in the page, seem a little bit odd

Describe the solution you'd like

photo_2024-08-08_15-53-24

**Screenshot **

image
image

@Fredrick2503
Copy link

How can I reproduce this issues?

@nihal467
Copy link
Member Author

nihal467 commented Aug 9, 2024

@Fredrick2503

How can I reproduce this issues?

  1. Login to the care
  2. go to the patient tab using the side bar
  3. click on the patient card with active consultation
  4. in the consultation page, below the diagnosis card, click on the medicine tab in the nav bar
  5. on your the medicine pages, click on the edit prescription button
  6. now you will be seeing the page mention related to first point
  7. now click on the print button
  8. now you will be seeing the page mention related to second point

@kushalbhana
Copy link
Contributor

Would love to work on it..

@Fredrick2503
Copy link

Can I be assigned to the issues as I would like to work on this issues

@nihal467
Copy link
Member Author

@Fredrick2503 / @kushalbhana are you still interested in working on this issue?

@kushalbhana
Copy link
Contributor

working on it...

@kushalbhana
Copy link
Contributor

just let me know Do I have to modify the css of all the components in this print preview to make it responsive
or is there any better way to do it

@rithviknishad
Copy link
Member

rithviknishad commented Aug 14, 2024

@kushalbhana No, scaling the inner contents of the PrintPreview contents manually using tailwindcss modifiers could be difficult to maintain. Instead you could use the scale-* tailwind class (or CSS equivalent) at the section-to-print of the reusable generic PrintPreview component instead.

I've opened a separate issue for this with a more detailed description here: #8323

Feel free to take that up

cc: @kushalbhana @Fredrick2503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants