Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PDF Viewer clipping out in different display zoom settings #8496

Merged

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Fixes PDF Viewer clipping out in different display zoom settings

Issue reported by @nihal467

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner September 6, 2024 10:03
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 4eaa2a7
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66dad37deff2ad00081dd527
😎 Deploy Preview https://deploy-preview-8496--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Sep 6, 2024

CARE    Run #3281

Run Properties:  status check passed Passed #3281  •  git commit 4eaa2a753b: Fixes PDF Viewer clipping out in different display zoom settings
Project CARE
Branch Review rithviknishad/fix/pdf-clipping-out-on-zoomed-in
Run status status check passed Passed #3281
Run duration 02m 56s
Commit git commit 4eaa2a753b: Fixes PDF Viewer clipping out in different display zoom settings
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 127
View all changes introduced in this branch ↗︎

@khavinshankar khavinshankar added reviewed reviewed by a core member and removed needs review labels Sep 6, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 9, 2024

LGTM

@khavinshankar khavinshankar merged commit b2a72c3 into develop Sep 10, 2024
28 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/pdf-clipping-out-on-zoomed-in branch September 10, 2024 08:06
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants